Issue with extraContainers placement in Kubernetes manifest

Summary

User reports an issue with extraContainers being incorrectly placed in extraVolumeMounts instead of Containers in a Kubernetes manifest, suggesting misindentation as the cause.


Question

I have added some extraContainers, I am seeing that its being placed in the extraVolumeMounts instead of Containers workload-api-server: https://github.com/airbytehq/airbyte-platform/blob/main/charts/airbyte-workload-api-server/templates/deployment.yaml#L190-L194

I believe that the nindents are incorrect based on other manifests layouts

When i look at my manifest it is doing this:

            - mountPath: /secrets/gcs-log-creds
              name: gcs-log-creds-volume
              readOnly: true
            - args:
                - '--private-ip'
                - '--structured-logs'
                - '--port=5432'
                - $(CONNECTION_NAME)
              env:
                - name: CONNECTION_NAME
                  valueFrom:
                    secretKeyRef:
                      key: instance_connection_name
                      name: postgres
              image: gcr.io/cloud-sql-connectors/cloud-sql-proxy:2.13.0
              name: cloud-sql-proxy
              resources:
                limits:
                  cpu: '1'
                  memory: 1Gi
              securityContext:
                runAsNonRoot: true
              volumeMounts: []```
the - args section is the extra container.

<br>

---

This topic has been created from a Slack thread to give it more visibility.
It will be on Read-Only mode here. [Click here](https://airbytehq.slack.com/archives/C021JANJ6TY/p1733407831398349) if you want
to access the original thread.

[Join the conversation on Slack](https://slack.airbyte.com)

<sub>
['kubernetes', 'extraContainers', 'manifest', 'volumeMounts']
</sub>

looking at the file i think that the extraVolumeMounts should actually be nindent 10

https://github.com/airbytehq/airbyte-platform/blob/main/charts/airbyte-workload-api-server/templates/deployment.yaml#L185-L188

The indentation is inconsistent across different components, but its internally consistent to that template (for the volume mounts)

But the args looks wrong

You are right, extra containers doesn’t look correct

It should be 2 less than extraVolume mounts, so 6

Can a fix be released for that?

hey <@U083W8D7U5S>, apologies for the belated response. Yes, we will get a fix out for this shortly