Summary
The user is questioning why primary keys are not declared for contacts and conversations streams in the source-intercom’s manifest.yml file. They are wondering if primary keys should be included for those streams.
Question
In source-intercom’s manifest.yml, why are primary keys not declared for contacts and conversations streams? I would think we’d want primary keys for those? Sorry I’m relatively new to the low-code side of airbyte.
https://github.com/airbytehq/airbyte/blob/a871899540a4bfc53a57311b0805c950c6ed9ec7/airbyte-integrations/connectors/source-intercom/source_intercom/manifest.yaml#L287-L299|https://github.com/airbytehq/airbyte/blob/a871899540a4bfc53a57311b0805c950c6ed9ec7[…]ations/connectors/source-intercom/source_intercom/manifest.yaml
This topic has been created from a Slack thread to give it more visibility.
It will be on Read-Only mode here. Click here if you want to access the original thread.
Join the conversation on Slack
["source-intercom", "manifest.yml", "primary-keys", "contacts-stream", "conversations-stream", "low-code", "airbyte"]
Based on the information provided in the extracts, it’s not explicitly stated why primary keys are not declared for the contacts and conversations streams in the source-intercom manifest file. However, it’s worth noting that in a Github issue, it was discussed that not all streams make sense to have a primary key. This could be the case for the contacts and conversations streams in the source-intercom connector. In another Github issue, it was mentioned that the contacts stream was passing undeclared columns, which could potentially be used as primary keys. However, the issue was about adding these undeclared columns to the spec, not necessarily about declaring them as primary keys. For a more definitive answer, you might want to check the Airbyte documentation or reach out to the Airbyte community for further clarification.
Might very well be worth filing an issue and making a PR with the change.
Having PKs would allow for more robust testing of those, too.